BaseCache._close() raises NotImplementedError

aio-libs · Mar 4, 2023 · 8caa687 · 8caa687
1 parent 604b00d
commit 8caa687
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/aiocache/base.py b/aiocache/base.py
@@ -511,7 +511,7 @@ async def close(self, *args, _conn=None, **kwargs):
 
     @abstractmethod
     async def _close(self, *args, **kwargs):
-        pass
+        raise NotImplementedError()
 
     @abstractmethod
     def build_key(self, key: str, namespace: Optional[str] = None) -> CacheKeyType:

diff --git a/tests/ut/test_base.py b/tests/ut/test_base.py
@@ -189,7 +189,8 @@ async def test_raw(self, base_cache):
             await base_cache._raw("get", Keys.KEY)
 
     async def test_close(self, base_cache):
-        assert await base_cache._close() is None
+        with pytest.raises(NotImplementedError):
+            await base_cache._close()
 
     async def test_acquire_conn(self, base_cache):
         assert await base_cache.acquire_conn() == base_cache