Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test for connection reuse for #10325 #10326

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jan 14, 2025

No description provided.

Copy link

codecov bot commented Jan 14, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
3463 1 3462 89
View the top 1 failed tests by shortest run time
tests.test_client_functional test_keepalive_post_empty_bytes[pyloop]
Stack Traces | 0.095s run time
[XPASS(strict)] Connection should be reused (#10325)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Copy link

codspeed-hq bot commented Jan 14, 2025

CodSpeed Performance Report

Merging #10326 will not alter performance

Comparing second_conn_reuse (68c23ea) with master (9482755)

Summary

✅ 47 untouched benchmarks

@Dreamsorcerer
Copy link
Member

Still a race condition that causes it to pass in a couple of test runs. Would be good if we can eliminate the race and make it predictable..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants