[iOS] Async animations support #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
60
to
64
| LottieView { | ||
| await LottieAnimation.loadedFrom(url: url) | ||
| } placeholder: { | ||
| LoadingIndicator() | ||
| } |
There was a problem hiding this comment.
Example call site for animation from URL
Comment on lines
83
to
87
| LottieView { | ||
| try await DotLottieFile.named(animationName) | ||
| } placeholder: { | ||
| LoadingIndicator() | ||
| } |
There was a problem hiding this comment.
Example callsite for loading a Dot lottie file
calda
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
This is great, thank you @miguel-jimenez-0529!
I pulled your branch and experimented a bit to help myself understand the requirements. I did a bit of cleanup in LottieView itself and pushed a commit with those changes. lmk what you think.
added 2 commits
July 26, 2023 15:08
calda
reviewed
Jul 26, 2023
| .getRealtimeAnimationProgress(animationPlaying ? $sliderValue : nil) | ||
|
|
||
| LottieView { | ||
| try await lottieSource() |
auto-merge was automatically disabled
July 26, 2023 20:56
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for loading async animations from sources such as:
The PR also