Update OC Compatiblity #2416
Closed
Update OC Compatiblity #2416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calda
reviewed
May 30, 2024
| var animation: LottieAnimation? { | ||
| LottieAnimation.named(name, bundle: bundle, subdirectory: subdirectory) | ||
| } | ||
| private(set) lazy var animation = LottieAnimation.named(name, bundle: bundle, subdirectory: subdirectory) |
There was a problem hiding this comment.
Instead, what if we just make this:
Suggested change
| private(set) lazy var animation = LottieAnimation.named(name, bundle: bundle, subdirectory: subdirectory) | |
| var animation: LottieAnimation |
and update the existing init to just:
public init(
name: String,
subdirectory: String? = nil,
bundle: Bundle = Bundle.main)
{
animation = LottieAnimation.named(name, bundle: bundle, subdirectory: subdirectory)
super.init()
}
|
Looks like the build is failing -- also make sure to run |
calda
reviewed
Jun 3, 2024
| @@ -46,6 +47,12 @@ public final class CompatibleAnimation: NSObject { | |||
| private let bundle: Bundle | |||
| } | |||
|
|
|||
| extension LottieAnimation { | |||
| public func ocCompatible() -> CompatibleAnimation { | |||
There was a problem hiding this comment.
Is this necessary? I'd prefer to keep the change focused on the new init
|
Still seeing build failures |
|
Since the build is failing I'm going to go ahead and close this PR for now. If you'd like, feel free to re-open the PR after fixing the build errors! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.