LottieAnimationView: update getValue(for:atFrame:) docs.
#2455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@calda I would appreciate your review on this, Thank you! |
The docs of this method weren't updated, this method will not work as expected when the Core Animation rendering engine is used. You can read more about it at the associated discussion: airbnb#2398
GalBerezansky
force-pushed
the
feature/fix-getValue-for-docs
branch
from
c8bfde6
to
5705dcc
Compare
calda
reviewed
Jul 29, 2024
calda
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs of this method weren't updated, this method will not work as expected when the Core Animation rendering engine is used. You can read more about it at the associated discussion: #2398 .