Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not crash if value is false #2482

Merged

Conversation

DarkSatyr
Copy link
Contributor

Our project is using KMP (Kotlin Multiplatform) and Kottie lib for crossplatform animations, Kottie uses Lottie inside and sets property respectAnimationFrameRate to false in it's default values
It would be great not to crash app, since value is not changing and it is false

Copy link
Member

@calda calda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks

@calda calda enabled auto-merge (squash) September 18, 2024 20:51
auto-merge was automatically disabled September 18, 2024 21:04

Head branch was pushed to by a user without write access

@calda calda enabled auto-merge (squash) September 18, 2024 21:22
@calda calda merged commit 9e8cd70 into airbnb:master Sep 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants