exclude the expected_spec files from the formatter

airbytehq · Sep 17, 2024 · e52c6bf · e52c6bf
1 parent 2e2fda6
commit e52c6bf
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/airbyte-cdk/bulk/core/load/src/testFixtures/kotlin/io/airbyte/cdk/test/spec/SpecTest.kt b/airbyte-cdk/bulk/core/load/src/testFixtures/kotlin/io/airbyte/cdk/test/spec/SpecTest.kt
@@ -12,6 +12,7 @@ import com.fasterxml.jackson.databind.ObjectMapper
 import io.airbyte.cdk.test.util.DestinationProcessFactory
 import io.airbyte.cdk.test.util.FakeDataDumper
 import io.airbyte.cdk.test.util.IntegrationTest
+import io.airbyte.cdk.test.util.NoopDestinationCleaner
 import io.airbyte.cdk.test.util.NoopExpectedRecordMapper
 import io.airbyte.protocol.models.Jsons
 import io.airbyte.protocol.models.v0.AirbyteMessage
@@ -34,7 +35,8 @@ private const val EXPECTED_SPEC_FILENAME = "expected_spec.json"
  */
 open abstract class SpecTest: IntegrationTest(
     FakeDataDumper,
-    NoopExpectedRecordMapper(),
+    NoopDestinationCleaner,
+    NoopExpectedRecordMapper,
 ) {
     @Test
     fun testSpec() {

diff --git a/airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/format/consts.py b/airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/format/consts.py
@@ -41,6 +41,7 @@
     "airbyte-ci/connectors/metadata_service/lib/metadata_service/models/generated/**",  # These files are generated and should not be formatted
     "**/airbyte-ci/connectors/metadata_service/lib/tests/fixtures/**/invalid",  # This is a test directory with invalid and sometimes unformatted code
     "airbyte-ci/connectors/pipelines/tests/test_format/non_formatted_code",  # This is a test directory with badly formatted code
+    "airbyte-integrations/connectors/destination-**/expected_spec.json", # These files are generated by tests using Jackson's pretty printer, and should not be reformatted.
 ]
 
 # In the airbyte-enterprise repo, the airbyte repo is included as a submodule.

diff --git a/airbyte-integrations/connectors/destination-e2e-test/expected_spec.json b/airbyte-integrations/connectors/destination-e2e-test/expected_spec.json
@@ -166,7 +166,8 @@
     },
     "required" : [ "test_destination" ]
   },
+  "supportsIncremental" : true,
   "supportsNormalization" : false,
   "supportsDBT" : false,
-  "supported_destination_sync_modes" : [ ]
-}
+  "supported_destination_sync_modes" : [ "overwrite", "append", "append_dedup" ]
+}