Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update homepage and product summary #45689

Merged
merged 10 commits into from
Sep 23, 2024
Merged

Conversation

nataliekwong
Copy link
Contributor

@nataliekwong nataliekwong commented Sep 20, 2024

What

  • Uses new box layout to showcase products and improve formatting
  • General updates for 1.0

Getting Started page:
Screenshot 2024-09-19 at 5 29 36 PM

Screenshot 2024-09-19 at 5 29 40 PM

Airbyte Overview page:
Screenshot 2024-09-20 at 9 38 04 AM

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 7:15pm

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Sep 20, 2024
@nataliekwong
Copy link
Contributor Author

@letiescanciano can you see if there is an issue with how I implemented the icons for faCloud, faLock and faDownload? It doesn't seem to render in the preview (it doesn't serve an error, but I don't see the icon appear as I do for when I use cloud, oss, enterprise). Would they render in the docs anyway even if they do not in the preview?

@nataliekwong
Copy link
Contributor Author

I also tried to use the secondary tag and it didn't seem to make those white like in your example. I'm not totally sure why! Not that important but was just a little puzzling.

@nataliekwong
Copy link
Contributor Author

fyi @Hesperide

docs/readme.md Outdated Show resolved Hide resolved
@letiescanciano
Copy link
Contributor

@letiescanciano can you see if there is an issue with how I implemented the icons for faCloud, faLock and faDownload? It doesn't seem to render in the preview (it doesn't serve an error, but I don't see the icon appear as I do for when I use cloud, oss, enterprise). Would they render in the docs anyway even if they do not in the preview?

should be fa-download fa-cloud or fa-lock I used names the same way they appeared on FontAwesome
Screenshot 2024-09-20 at 17 38 39

Copy link
Contributor

@letiescanciano letiescanciano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nataliekwong nataliekwong merged commit ec65718 into master Sep 23, 2024
30 checks passed
@nataliekwong nataliekwong deleted the natalie/docs-homepage branch September 23, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants