Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete local AssetLoader class, update dependencies (#46) #50

Merged
merged 2 commits into from
Jul 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,17 @@
## [0.0.1]
## 2.0.0

- initial release
- **BREAKING**: The local `AssetLoader` class deleted, now using the one from
[easy_localization](https://pub.dev/documentation/easy_localization/latest/easy_localization/AssetLoader-class.html) itself.
- **BREAKING**: Depends on [connectivity_plus](https://pub.dev/packages/connectivity_plus) ^4.0.0
and [http](https://pub.dev/packages/http) ^1.0.0.
- Const constructors in:
- `FileAssetLoader`
- `HttpAssetLoader`
- `JsonAssetLoader`
- `TestsAssetLoader`
- `XmlAssetLoader`
- `YamlAssetLoader`

## 0.0.1

- Initial release.
12 changes: 5 additions & 7 deletions lib/easy_localization_loader.dart
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
library easy_localization_loader;

export 'package:easy_localization_loader/src/csv_asset_loader.dart';
export 'package:easy_localization_loader/src/file_asset_loader.dart';
export 'package:easy_localization_loader/src/json_asset_loader.dart';
export 'package:easy_localization_loader/src/http_asset_loader.dart';
export 'package:easy_localization_loader/src/csv_asset_loader.dart';
export 'package:easy_localization_loader/src/yaml_asset_loader.dart';
export 'package:easy_localization_loader/src/xml_asset_loader.dart';
export 'package:easy_localization_loader/src/tests_asset_loader.dart';
export 'package:easy_localization_loader/src/json_asset_loader.dart';
export 'package:easy_localization_loader/src/smart_network_asset_loader.dart';
export 'package:easy_localization_loader/src/tests_asset_loader.dart';
export 'package:easy_localization_loader/src/xml_asset_loader.dart';
export 'package:easy_localization_loader/src/yaml_asset_loader.dart';
27 changes: 0 additions & 27 deletions lib/src/asset_loader.dart

This file was deleted.

3 changes: 1 addition & 2 deletions lib/src/csv_asset_loader.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,9 @@ import 'dart:ui';

import 'package:csv/csv.dart';
import 'package:csv/csv_settings_autodetection.dart';
import 'package:easy_localization/easy_localization.dart';
import 'package:flutter/services.dart';

import 'asset_loader.dart';

//
// load example/resources/langs/langs.csv
//
Expand Down
8 changes: 3 additions & 5 deletions lib/src/file_asset_loader.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,11 @@ import 'dart:developer';
import 'dart:io';
import 'dart:ui';

import 'asset_loader.dart';
import 'package:easy_localization/easy_localization.dart';

//
//
//
//
class FileAssetLoader extends AssetLoader {
const FileAssetLoader();

@override
Future<Map<String, dynamic>> load(String path, Locale locale) async {
final file = File(path);
Expand Down
9 changes: 3 additions & 6 deletions lib/src/http_asset_loader.dart
Original file line number Diff line number Diff line change
@@ -1,16 +1,13 @@
//
//
//
//
import 'dart:convert';
import 'dart:developer';
import 'dart:ui';

import 'package:easy_localization/easy_localization.dart';
import 'package:http/http.dart' as http;

import 'asset_loader.dart';

class HttpAssetLoader extends AssetLoader {
const HttpAssetLoader();

@override
Future<Map<String, dynamic>> load(String path, Locale locale) async {
log('easy localization loader: load http $path');
Expand Down
7 changes: 4 additions & 3 deletions lib/src/json_asset_loader.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,14 @@ import 'dart:convert';
import 'dart:developer';
import 'dart:ui';

import 'package:easy_localization/easy_localization.dart';
import 'package:flutter/services.dart';

import 'asset_loader.dart';

class JsonAssetLoader extends AssetLoader {
const JsonAssetLoader();

String getLocalePath(String basePath, Locale locale) {
return '$basePath/${localeToString(locale, separator: "-")}.json';
return '$basePath/${locale.toStringWithSeparator(separator: "-")}.json';
}

@override
Expand Down
3 changes: 1 addition & 2 deletions lib/src/smart_network_asset_loader.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,12 @@ import 'dart:convert';
import 'dart:io';
import 'dart:ui';
import 'package:connectivity_plus/connectivity_plus.dart';
import 'package:easy_localization/easy_localization.dart';
import 'package:http/http.dart' as http;
import 'package:path_provider/path_provider.dart' as paths;

import 'package:flutter/services.dart';

import 'asset_loader.dart';

/// ```dart
/// SmartNetworkAssetLoader(
/// assetsPath: 'assets/translations',
Expand Down
5 changes: 3 additions & 2 deletions lib/src/tests_asset_loader.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,15 @@ import 'dart:convert';

import 'dart:ui';

import 'package:easy_localization/easy_localization.dart';
import 'package:flutter/services.dart';

import 'asset_loader.dart';

// asset loader to be used when doing integration tests
// default AssetLoader suffers from this issue
// https://github.com/flutter/flutter/issues/44182
class TestsAssetLoader extends AssetLoader {
const TestsAssetLoader();

@override
Future<Map<String, dynamic>> load(String path, Locale locale) async {
final byteData = await rootBundle.load(path);
Expand Down
7 changes: 4 additions & 3 deletions lib/src/xml_asset_loader.dart
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
import 'dart:developer';
import 'dart:ui';

import 'package:easy_localization/easy_localization.dart';
import 'package:flutter/services.dart';
import 'package:xml/xml.dart';

import 'asset_loader.dart';

//Loader for multiple xml files
class XmlAssetLoader extends AssetLoader {
const XmlAssetLoader();

String getLocalePath(String basePath, Locale locale) {
return '$basePath/${localeToString(locale, separator: "-")}.xml';
return '$basePath/${locale.toStringWithSeparator(separator: "-")}.xml';
}

@override
Expand Down
7 changes: 4 additions & 3 deletions lib/src/yaml_asset_loader.dart
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
import 'dart:developer';
import 'dart:ui';

import 'package:easy_localization/easy_localization.dart';
import 'package:flutter/services.dart';
import 'package:yaml/yaml.dart';

import 'asset_loader.dart';

//Loader for multiple yaml files
class YamlAssetLoader extends AssetLoader {
const YamlAssetLoader();

String getLocalePath(String basePath, Locale locale) {
return '$basePath/${localeToString(locale, separator: "-")}.yaml';
return '$basePath/${locale.toStringWithSeparator(separator: "-")}.yaml';
}

@override
Expand Down
17 changes: 8 additions & 9 deletions pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,22 +4,21 @@ description: Easy Localization Loader custom assets loaders for easy_localizatio
homepage: https://github.com/aissat/easy_localization_loader
issue_tracker: https://github.com/aissat/easy_localization_loader/issues

version: 1.0.1+1
version: 2.0.0

environment:
sdk: '>=2.12.0-0 <3.0.0'
sdk: '>=2.12.0 <4.0.0'

dependencies:
http: ^0.13.5
connectivity_plus: ^4.0.0
csv: ^5.0.1
yaml: ^3.1.1
xml: ^6.1.0
flutter:
sdk: flutter
connectivity_plus: ^2.3.7
easy_localization: ^3.0.2
flutter: { sdk: flutter }
http: ^1.0.0
path_provider: ^2.0.11
xml: ^6.1.0
yaml: ^3.1.1

dev_dependencies:
pedantic: ^1.11.1
test: ^1.21.6