Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component upgrade throws a false "false unused pins" error (non blocker issue) #98

Open
ceremcem opened this issue Sep 8, 2022 · 0 comments
Labels

Comments

@ceremcem
Copy link
Collaborator

ceremcem commented Sep 8, 2022

Reproduction

Use a subcircuit (eg. Max232 circuit)
Do not use some of its pins in the parent circuit, there by define that unused pins in no-connect: section.
Any component upgrade will throw a false "false unused pins" error.

This error is not blocker, simply ignore this error.

Responsible code:

# TEMPORARY SECTION: Create a @_netlist object now
# ------------------------------------------------
for net in x=(net-merge _data_netlist)
# We no longer need numeric labels and interface descriptions.
netlabel = null # only one label is allowed for a net
iface = null
iface-label = null
_net = []
for elem in net
if label=(elem.match /^__label:(.+)$/)?.1
# Use labels if labels are present
iface-label = label
continue
if i=(elem.match /^__iface:[^.]+\.(.+)$/)?.1
# Remove temporary interface entries
iface = i
continue
if i=(elem.match /^__iface:(.+)$/)?.1
# Remove temporary interface entries
iface = i
continue
if netid=(elem.match /^__netid:(.+)$/)?.1
# this is an alphanumeric label
if netid.match internal-numeric-netid-syntax
# that's a number
unless netlabel
netlabel = netid
continue
else
# that's an alphanumeric label, replace with current label
if not netlabel or netlabel.match internal-numeric-netid-syntax
netlabel = netid
continue
else
# Add additional netlabel's to the net
_net.push netid
continue
if elem.match internal-numeric-netid-syntax
# no need for numerical netlabels
continue
_net.push elem
netid = iface-label or iface or netlabel
_netlist[netid] = _net.filter (isnt netid) |> unique
# ------------------------------------------------
# End of temporary section

Solution

The @_netlist object should not contain the unused, label-pin connections.

@ceremcem ceremcem added the bug label Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant