Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): stage/freight live manifest scrolls infinitely #2550

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

rbreeze
Copy link
Contributor

@rbreeze rbreeze commented Sep 19, 2024

Fixes #2523

@rbreeze rbreeze requested a review from a team as a code owner September 19, 2024 17:11
Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 9df49d1
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66ec5c2fa8fd15000862f726
😎 Deploy Preview https://deploy-preview-2550.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Remington Breeze <[email protected]>
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.57%. Comparing base (bbec37d) to head (9df49d1).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2550   +/-   ##
=======================================
  Coverage   50.57%   50.57%           
=======================================
  Files         278      278           
  Lines       20428    20428           
=======================================
  Hits        10331    10331           
  Misses       9462     9462           
  Partials      635      635           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Marvin9 Marvin9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this in stage and freight live manifest view and LGTM!

@krancour krancour added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit 12a8eb8 Sep 23, 2024
23 checks passed
@krancour krancour deleted the rbreeze/inf-manifest-height branch September 23, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(ui): live manifest of stage has ever-expanding text box
3 participants