Fix: participation key rendering from base64url to base64 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larkiny
approved these changes
Jan 17, 2025
tasosbit
force-pushed
the
fix/keys-view-base64-encoding
branch
from
49a3363 to
1c48eb6
Compare
Deploying nodekit-run with
|
| Latest commit: |
85a8ff1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4b30fc43.nodekit-run.pages.dev |
| Branch Preview URL: | https://fix-keys-view-base64-encodin.nodekit-run.pages.dev |
tasosbit
force-pushed
the
fix/keys-view-base64-encoding
branch
3 times, most recently
from
1aa6dd8 to
df605da
Compare
tasosbit
force-pushed
the
fix/keys-view-base64-encoding
branch
from
df605da to
85a8ff1
Compare
PhearZero
approved these changes
Jan 20, 2025
tasosbit
pushed a commit
that referenced
this pull request
Jan 22, 2025
…encoding Fix: participation key rendering from base64url to base64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ Overview
The key info modal rendered the participation keys with base64url
The expected format is base64 with padding, as goal outputs. This fixes copy-pastability to 3rd party tools that may not support base64url.
✅ Acceptance: