Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: installer env vars enabling unattended installation #143

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

tasosbit
Copy link
Contributor

@tasosbit tasosbit commented Feb 6, 2025

ℹ Overview

Introduces the NODEKIT_FORCE_INSTALL and NODEKIT_SKIP_BOOTSTRAP environment variables to the installer. These are considered enabled if they are set to any non-zero-length string.

NODEKIT_FORCE_INSTALL - replace existing nodekit without prompting
NODEKIT_SKIP_BOOTSTRAP - skip the final bootstrap step

The two can be used to script an unattended installation of nodekit, e.g. with:

wget -qO- https://nodekit.run/install.sh | NODEKIT_FORCE_INSTALL=1 NODEKIT_SKIP_BOOTSTRAP=1 bash

Example usage has been added under unattended.sh

📝 Related Issues

✅ Acceptance:

  • Pre-commit checks pass

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v1.2.2@8890f4c). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             v1.2.2     #143   +/-   ##
=========================================
  Coverage          ?   32.63%           
=========================================
  Files             ?       76           
  Lines             ?     6342           
  Branches          ?        0           
=========================================
  Hits              ?     2070           
  Misses            ?     4160           
  Partials          ?      112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tasosbit tasosbit force-pushed the feat/installer-without-bootstrap-env-var branch from b14bc26 to f5119fa Compare February 6, 2025 14:06
Copy link

cloudflare-workers-and-pages bot commented Feb 6, 2025

Deploying nodekit-run with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5c60f9b
Status: ✅  Deploy successful!
Preview URL: https://5e3305a7.nodekit-run.pages.dev
Branch Preview URL: https://feat-installer-without-boots.nodekit-run.pages.dev

View logs

@tasosbit tasosbit requested a review from PhearZero February 6, 2025 14:09
Copy link
Member

@PhearZero PhearZero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (install.sh Ubuntu+Darwin)

Small nit: execute bit on unattended.sh

@tasosbit tasosbit force-pushed the feat/installer-without-bootstrap-env-var branch from f5119fa to 5c60f9b Compare February 10, 2025 16:32
@tasosbit tasosbit changed the base branch from main to v1.2.2 February 11, 2025 11:55
@tasosbit tasosbit merged commit 824d04d into v1.2.2 Feb 12, 2025
4 checks passed
@tasosbit tasosbit deleted the feat/installer-without-bootstrap-env-var branch February 12, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants