Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: keyreg offline page on nodekit.run/offline #145

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

tasosbit
Copy link
Contributor

@tasosbit tasosbit commented Feb 10, 2025

ℹ Overview

Test link: https://docs-keyreg-offline-page.nodekit-run.pages.dev/offline

  • Adds a keyreg offline utility for deployment on nodekit.run/off
    • This searches account addresses or NFDs and links to Lora for a quick keyreg account

✅ Acceptance:

  • Pre-commit checks pass

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.22%. Comparing base (ce782cb) to head (86a03f7).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
- Coverage   32.63%   32.22%   -0.42%     
==========================================
  Files          76       76              
  Lines        6342     6423      +81     
==========================================
  Hits         2070     2070              
- Misses       4160     4241      +81     
  Partials      112      112              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cloudflare-workers-and-pages bot commented Feb 10, 2025

Deploying nodekit-run with  Cloudflare Pages  Cloudflare Pages

Latest commit: 86a03f7
Status: ✅  Deploy successful!
Preview URL: https://3b4a4fad.nodekit-run.pages.dev
Branch Preview URL: https://docs-keyreg-offline-page.nodekit-run.pages.dev

View logs

@PhearZero PhearZero changed the base branch from main to v1.2.2 February 10, 2025 17:37
@PhearZero
Copy link
Member

PhearZero commented Feb 10, 2025

@tasosbit feel free to rebase the fix and change the base back to main (prevent point release). Otherwise we can roll it into the QR update

@tasosbit tasosbit force-pushed the docs/keyreg-offline-page branch from ed40cf8 to f335d2a Compare February 11, 2025 11:39
@tasosbit tasosbit changed the title Docs: keyreg offline page on nodekit.run/off Docs: keyreg offline page on nodekit.run/offline Feb 11, 2025
@tasosbit tasosbit force-pushed the docs/keyreg-offline-page branch from c809f8f to 923b7c4 Compare February 11, 2025 11:55
@tasosbit tasosbit requested a review from PhearZero February 11, 2025 13:17
Copy link
Member

@PhearZero PhearZero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, smh didn't even use @awesome-algorand/nfd-fetch

@tasosbit tasosbit force-pushed the docs/keyreg-offline-page branch from 923b7c4 to 3f2f7e5 Compare February 12, 2025 10:48
@tasosbit tasosbit changed the base branch from v1.2.2 to main February 12, 2025 10:50
@tasosbit tasosbit force-pushed the docs/keyreg-offline-page branch from 3f2f7e5 to 86a03f7 Compare February 12, 2025 10:53
@tasosbit tasosbit merged commit fdd784b into main Feb 12, 2025
4 checks passed
@tasosbit tasosbit deleted the docs/keyreg-offline-page branch February 12, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants