Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable QR signing #146

Merged
merged 1 commit into from
Feb 12, 2025
Merged

fix: enable QR signing #146

merged 1 commit into from
Feb 12, 2025

Conversation

tasosbit
Copy link
Contributor

ℹ Overview

Re-enabling QR code based signing

✅ Acceptance:

  • Pre-commit checks pass

Copy link

Deploying nodekit-run with  Cloudflare Pages  Cloudflare Pages

Latest commit: a2eecd5
Status: ✅  Deploy successful!
Preview URL: https://db327cea.nodekit-run.pages.dev
Branch Preview URL: https://fix-enable-qr.nodekit-run.pages.dev

View logs

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.22%. Comparing base (5c60f9b) to head (a2eecd5).
Report is 8 commits behind head on v1.2.2.

Additional details and impacted files
@@            Coverage Diff             @@
##           v1.2.2     #146      +/-   ##
==========================================
- Coverage   32.63%   32.22%   -0.42%     
==========================================
  Files          76       76              
  Lines        6342     6423      +81     
==========================================
  Hits         2070     2070              
- Misses       4160     4241      +81     
  Partials      112      112              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tasosbit tasosbit requested a review from PhearZero February 12, 2025 14:41
@tasosbit tasosbit merged commit d23436d into v1.2.2 Feb 12, 2025
4 checks passed
@tasosbit tasosbit deleted the fix/enable-qr branch February 12, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants