Skip to content

Commit

Permalink
Fix gha smells:
Browse files Browse the repository at this point in the history
- Use fixed version for runs-on argument
- Run tests on multiple OS's
- Avoid workflows without comments
  • Loading branch information
ceddy4395 committed May 24, 2024
1 parent dbd3c06 commit 1b8fb56
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
5 changes: 4 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,13 @@ on:

jobs:
build:
runs-on: ubuntu-latest
name: Build on ${{matrix.os}} with Java ${{matrix.java}}
runs-on: ${{matrix.os}}
strategy:
fail-fast: false
matrix:
java: [8, 11, 17, 21]
os: [ubunutu-latest, windows-latest]
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/document-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@ jobs:
- name: Checkout
uses: actions/checkout@v4

- run: npm install -g markdownlint-cli

- run: npm install -g [email protected]
# Run markdown lint with the following rules disabled:
# no hard tabs, line length, no duplicate heading, ordered list item prefix, no inline html and no emphasis as heading
- name: use markdownlint-cli to lint markdown file
run: |
find ./ -name "*.md" | grep -v vendor | grep -v commandline | grep -v .github | grep -v swagger | grep -v api | \
Expand Down

0 comments on commit 1b8fb56

Please sign in to comment.