[server] Cdc log visible only when the data already flush to rocksDb from preWriteBuffer #179
+284
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from preWriteBuffer
2 tasks
wuchong
reviewed
Feb 27, 2025
| * The base test class for client to server request and response. The server include | ||
| * CoordinatorServer and TabletServer. | ||
| */ | ||
| public class ClientToServerITCaseUtils { |
| "AckedLogEndOffset update from {} to {}.", messageOffset, newAckedLogEndOffset); | ||
|
|
||
| // when ackedLogEndOffset advanced, we may need to flush kv if it's kv replica | ||
| mayFlushKv(newAckedLogEndOffset.getMessageOffset()); |
There was a problem hiding this comment.
maybe we can simplify flush kv first, and then update high-watermark? Our purpose is just make KV ready before log is available. This can avoid introducing additional variable ackedLogEndOffsetMetadata (it is quite complex if we need to handle the restore of the new variable).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pr is aims to fix the visibility of the CDC log, it should only become visible after the KV data has been flushed to RocksDb.
Linked issue: #134
Tests
API and Format
Documentation