-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flink] Upgrade sink connector to new API version #205
[flink] Upgrade sink connector to new API version #205
Conversation
LGTM, cc @wuchong. |
...ector-flink/src/main/java/com/alibaba/fluss/connector/flink/sink/writer/FlinkSinkWriter.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late reviewing and thanks @michaelkoepf for the contribution. The changes looks good to me in general. Could you rebase the branch to latest main
branch to resolve the conflicts?
...onnector-flink/src/test/java/com/alibaba/fluss/connector/flink/sink/FlinkSinkWriterTest.java
Outdated
Show resolved
Hide resolved
...rs/fluss-connector-flink/src/main/java/com/alibaba/fluss/connector/flink/sink/FlinkSink.java
Outdated
Show resolved
Hide resolved
9c08511
to
2da3bdc
Compare
@wuchong addressed feedback and rebased, ptal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updating. LGTM.
2da3bdc
to
5f93c5f
Compare
Hi @michaelkoepf , I know why the CI is stuck on Lines 92 to 96 in 70229b8
|
@wuchong i will look into the suggested issue. |
2132b2a
to
2da3bdc
Compare
- Upgraded sink connector from deprecated RichSinkFunction to new Sink interface - Adapted corresponding unit test cases Issue alibaba#132
- Adapted access modifiers - Consistent naming Issue alibaba#132
2da3bdc
to
6dd724f
Compare
@wuchong fixed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Purpose
Linked issue: close #132
Upgrade sink connector from deprecated RichSinkFunction (will be removed in Flink 2.0) to new Sink interface
Tests
com.alibaba.fluss.connector.flink.sink.FlinkSinkWriterTest.java
com.alibaba.fluss.connector.flink.sink.FlinkTableSinkITCase.java
API and Format
n/a
Documentation
n/a