Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[client] Fix NullPointerException when deleting on a primary key table which enabled data lake #481

Merged
merged 1 commit into from
Feb 25, 2025
Merged

[client] Fix NullPointerException when deleting on a primary key table which enabled data lake #481

merged 1 commit into from
Feb 25, 2025

Conversation

wuchong
Copy link
Member

@wuchong wuchong commented Feb 25, 2025

Purpose

Linked issue: close #299

This has been fixed in #362. Just add a test case to cover this.

Tests

Added an IT case in FlussLakeTableITCase.

API and Format

Documentation

@wuchong wuchong marked this pull request as ready for review February 25, 2025 08:17
@wuchong wuchong requested a review from luoyuxia February 25, 2025 08:17
luoyuxia
luoyuxia approved these changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@luoyuxia luoyuxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wuchong LGTM!

@wuchong wuchong merged commit 0d2dc59 into alibaba:main Feb 25, 2025
2 checks passed
@wuchong wuchong deleted the delete-on-lake-pk-table branch February 25, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luoyuxia luoyuxia luoyuxia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete on a primary key table which enabled data lake will throw NullPointerException
2 participants
@wuchong @luoyuxia