Feature/add iso 8601 timestamp serialization #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…time or local + offset in serialization and deserialization
…01-timestamp-serialization
jmartinez5120
requested changes
Aug 29, 2024
...main/java/io/americanexpress/synapse/utilities/common/serialization/InstantDeserializer.java
Show resolved
Hide resolved
...c/main/java/io/americanexpress/synapse/utilities/common/serialization/InstantSerializer.java
Show resolved
Hide resolved
jmartinez5120
requested changes
Aug 29, 2024
| .append(DateTimeFormatter.ISO_LOCAL_TIME) | ||
| .appendLiteral('Z') | ||
| .toFormatter() | ||
| .withZone(ZoneOffset.UTC); |
There was a problem hiding this comment.
If we set the Zone, do we need to append the Literal Z?
There was a problem hiding this comment.
Yes we do otherwise, we end up getting the string back as "2024-08-30T14:48:34.857239" even though the java Instant object value was actually 2024-08-30T14:48:34.857239Z. The numbers all look correct but we miss the Z if we remove the appendLiteral. If we remove the withZone then we get a parsing error entirely
...main/java/io/americanexpress/synapse/utilities/common/serialization/InstantDeserializer.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently ISO-8601 can't be serialized with the existing date time formatters when creating a
LocalDateTImeobject. Additionally, theLocalDateTimeobject does not capture the current time in UTC which can lead to discrepancies across servers. To avoid this issue, we can use theInstantclass.This class captures a timezone in ISO-8601 format (yyyy-MM-dd'T'HH:mm:ss.SSSSSSSSS'Z'). There are 2 variations on the input:
2023-10-06T15:50Z2023-10-06T15:50+02:00will convert to2023-10-06T13:50ZTo enable this behavior, a custom serializer / deserializer is added to allow optional seconds. By default the seconds are not optional, only the milliseconds are.