Remove conflicting copy of NIO method #141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In amzn#98, @tachyonics added a vendored copy of a NIO method on EventLoopFuture to avoid needing to add availability guards. I don't think that should have been necessary then, but it certainly isn't now, as smoke-http's minimum deployment targets match the extension in NIO. This extension contravened one of NIO's requirements on its dependencies: https://github.com/apple/swift-nio/blob/main/docs/public-api.md#4-extending-nio-types. Ideally when it was added, it should have been given a different name. This extension has been working, but it is now conflicting with NIO's main on Swift 5.9. This patch removes the now-vestigial extension, as it isn't needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #98, @tachyonics added a vendored copy of a NIO method on EventLoopFuture to avoid needing to add availability guards. I don't think that should have been necessary then, but it certainly isn't now, as smoke-http's minimum deployment targets match the extension in NIO.
This extension contravened one of NIO's requirements on its dependencies: https://github.com/apple/swift-nio/blob/main/docs/public-api.md#4-extending-nio-types. Ideally when it was added, it should have been given a different name.
This extension has been working, but it is now conflicting with NIO's main on Swift 5.9. This patch removes the now-vestigial extension, as it isn't needed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.