-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for ADF4382 #626
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: chegbeli <[email protected]>
In the driver reference_doubler has been renamed to reference_doubler_en. Signed-off-by: chegbeli <[email protected]>
Signed-off-by: chegbeli <[email protected]>
The IIO attribute list has been updated and the python support for the ADF4382 had to have a corresponding update as well Signed-off-by: chegbeli <[email protected]>
The IIO attribute list has been updated, the example file has also been updated to match the new names and expected values. Signed-off-by: chegbeli <[email protected]>
Signed-off-by: chegbeli <[email protected]>
Signed-off-by: chegbeli <[email protected]>
There are some cases where driver will have different attributes based on Linux vs No-OS solutions. In order to have a unified test for both scenarios, this marker will be used to differentiate between them. Signed-off-by: chegbeli <[email protected]>
This will test out the ranges of the IIO attributes which can be read form the register space. Some attributes are only present in the No-OS solution and require the use of the No-OS marker. Signed-off-by: chegbeli <[email protected]>
Signed-off-by: chegbeli <[email protected]>
Signed-off-by: chegbeli <[email protected]>
Added the debug attributes for direct register access over the IIO interface. Signed-off-by: chegbeli <[email protected]>
Added the debug example for direct register access over the IIO interface. Signed-off-by: chegbeli <[email protected]>
Signed-off-by: Jude Osemene <[email protected]>
Test Results1 611 tests +12 402 ✅ ± 0 12m 6s ⏱️ ±0s Results for commit 955b963. ± Comparison against base commit c7c4ca6. This pull request removes 4 and adds 16 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Generated documentation for this PR is available at Link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally in good shape. Just a couple things:
- Need docstring on all public properties
- Will any variants support more or less channels? If so it might be useful to use channel objects instead of a flat struct of the output individual channel controls. Similar to this class https://github.com/analogdevicesinc/pyadi-iio/blob/main/adi/ad7746.py
Signed-off-by: Jude Osemene
b1ba6d9
to
955b963
Compare
Hi Travis, It is all sorted now. I left the the attribute structure as is because the channels will remain consistent across all the ADF4382 variants. If this is a mandatory change, then let me know, and I will reformat the class. Thanks |
Description
Add adf4382.py driver
Add example script for example_adf4382.py
Update index.rst, init.py, supported_parts.md files
Fixes # (issue)
Type of change
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Documentation
If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.
Checklist: