Merge pull request #177 from andersonba/fix-falsy-skip

fix falsy skip
andersonba · Aug 4, 2019 · 45b891f · 45b891f
2 parents e4c3229 + d2d2754
commit 45b891f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/core/__tests__/bot.spec.ts b/src/core/__tests__/bot.spec.ts
@@ -66,6 +66,7 @@ test('sanitize rule', () => {
         synonyms: 1, one, oNe,ONE
   - type: SingleChoice
     multiline: false
+  - skip: false
   `);
   const bot = new YveBot(rules, OPTS);
   expect(bot.rules[0].message).toBe('Hello');
@@ -76,6 +77,7 @@ test('sanitize rule', () => {
   expect(bot.rules[2].skip({})).toBeTruthy();
   expect(bot.rules[3].options[0].synonyms).toEqual(['1', 'one', 'oNe', 'ONE']);
   expect(bot.rules[4].multiline).toBeFalsy();
+  expect(bot.rules[5].skip({})).toBeFalsy();
 });
 
 test('convert flows to rules', () => {

diff --git a/src/core/sanitizers.ts b/src/core/sanitizers.ts
@@ -48,8 +48,9 @@ export function sanitizeRule(input: IRule): IRule {
 
   if (typeof rule.skip === 'undefined') {
     rule.skip = () => false;
-  } else {
-    rule.skip = typeof rule.skip === 'function' ? rule.skip : () => !!rule.skip;
+  } else if (typeof rule.skip !== 'function') {
+    const value = !!rule.skip;
+    rule.skip = () => value;
   }
 
   // string way