Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintenance: remove lockfile #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

castarco
Copy link

@castarco castarco commented Feb 7, 2023

In this MR, I fix two aspects of the pg-listen package:

  • I remove the package-lock.json file from being tracked by git. Lockfiles make sense for applications, but can be dangerous for libraries:
    • as they can make it more difficult to upgrade transitive dependencies for package consumers.
    • and because it's easy to manipulate them bypassing code review process.

src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@@ -27,7 +27,7 @@
"dependencies": {
"debug": "^4.1.1",
"pg-format": "^1.0.4",
"typed-emitter": "^0.1.0"
"typed-emitter": "^1.0.0"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were no breaking changes in versions 0.2.0 and 1.0.0.

@xgalen
Copy link

xgalen commented Mar 2, 2023

Hey @castarco this project seems to be abandoned. Have you considered asking the author to let you manage it?

@castarco
Copy link
Author

castarco commented Mar 2, 2023

Hey @castarco this project seems to be abandoned. Have you considered asking the author to let you manage it?

Hi @xgalen , I didn't think about it. I have severe ADHD and I could burn out quickly being the sole maintainer of a package used by so many people. I see myself helping only if it keeps being a group endeavour.

@castarco castarco changed the title fix: undefined vars maintenance: remove lockfile Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants