New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing config option in example #352

Open

pauby wants to merge 1 commit into anishathalye:master from pauby:fix/missing-config-option

pauby commented Dec 23, 2023 •

edited

Loading

I used the example highlighted in the PR, and it didn't work. On looking at the docs more closely, it says:

When glob: True, Dotbot uses [glob.glob](https://docs.python.org/3/library/glob.html#glob.glob) to resolve glob paths, expanding Unix shell-style wildcards, which are not the same as regular expressions; Only the following are expanded:

I took this to mean that glob: true must be used if you want glob patterns to be expanded. Once I did that, everything worked as it should have.

So I think the example is just missing this option and thought I'd submit this PR to fix it.


          Fix missing config option in example

a06c5d1

kurtmckee approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet