Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update config.js #1167 #1170

Closed
wants to merge 1 commit into from
Closed

update config.js #1167 #1170

wants to merge 1 commit into from

Conversation

msaini28r
Copy link

@msaini28r msaini28r commented Oct 14, 2021

I have added the medium option to the issue. #1167

Description

Fixes # [ISSUE]

Type of Change:

  • Code
  • Quality Assurance
  • User Interface
  • Outreach
  • Documentation

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged
  • I have written Kotlin Docs whenever is applicable

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

I have added the medium option .
@msaini28r
Copy link
Author

issue solved. #1167

1 similar comment
@msaini28r
Copy link
Author

issue solved. #1167

@epicadk
Copy link
Member

epicadk commented Oct 14, 2021

Thanks. But please have a look at the contributing guidelines https://github.com/anitab-org/mentorship-android#contributing. Next time make sure the issues is assigned to you before opening a pr.

cc @isabelcosta

@msaini28r
Copy link
Author

msaini28r commented Oct 14, 2021 via email

@isabelcosta
Copy link
Member

Have i done something wrong?

The work is great! Thank you for solving this!

However, @msaini0r according to our guidelines, this issue is assigned to another contributor, so we want to give them a chance to solve the issue. I am sure this will be useful to the assigned contributor. Will close, but please feel free to solve other issues!

@isabelcosta
Copy link
Member

@msaini0r you can pick an issue if available, and then we can assign to you and you can work on it :) 💪🏾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants