Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge unique auth classes in the keycloak dynaconf hook. #2271

Merged
merged 11 commits into from
Sep 23, 2024
Merged

Merge unique auth classes in the keycloak dynaconf hook. #2271

merged 11 commits into from
Sep 23, 2024

Conversation

jctanner
Copy link
Collaborator

@jctanner jctanner changed the title Merge unqiue auth classes in the keycloak dynaconf hook. Merge unique auth classes in the keycloak dynaconf hook. Sep 20, 2024
@github-actions github-actions bot added backport-4.9 This PR should be backported to stable-4.9 (2.4) backport-4.10 labels Sep 20, 2024
@rochacbruno
Copy link
Member

Does it need backport to 4.9? I think only 4.10 is enough.

@jctanner jctanner removed backport-4.9 This PR should be backported to stable-4.9 (2.4) backport-4.10 labels Sep 20, 2024
@jctanner
Copy link
Collaborator Author

Downstream test result after manual patching ...

[root@ip-10-0-11-11 ~]# pulpcore-manager shell -c 'from django.conf import settings; print(settings.GALAXY_AUTHENTICATION_CLASSES)'
['ansible_base.jwt_consumer.hub.auth.HubJWTAuth', 'rest_framework.authentication.TokenAuthentication', 'rest_framework.authentication.BasicAuthentication', 'galaxy_ng.app.auth.session.SessionAuthentication', 'galaxy_ng.app.auth.token.ExpiringTokenAuthentication', 'galaxy_ng.app.auth.keycloak.KeycloakBasicAuth']

@jctanner
Copy link
Collaborator Author

No backports required yet, as this scenario only applies to 2.5 upgrades

@jctanner
Try this.
da6d4b2 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Try this ...
72f5f80 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Change the keycloak initial classes ...
1a5c232 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Merge branch 'master' into KEYCLOAK_DYNACONF_AUTH_CLASS_MERGE
ae8612e
@jctanner
Lint cleanup.
4276cb3 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
More lint fixes.
38adb3b 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
CLeanup.
ce2cf9e 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
More cleanup.
082ec0a 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
More cleanup.
0b5e809 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Enable default kwargs.
d1ee6cc 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner jctanner merged commit 0a45a9d into ansible:master Sep 23, 2024
19 of 22 checks passed
@patchback Patchback
Copy link

patchback bot commented Oct 17, 2024 •
edited
Loading

Backport to stable-4.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.10/0a45a9de4b1570135c3e2b979fa643e15cb1bd6c/pr-2271

Backported as #2318

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 17, 2024
@jctanner @patchback
Merge unique auth classes in the keycloak dynaconf hook. (#2271)
3939d75 
Refactor the auth class injection code to be more aware of dab requirements and AAP upgrades.

No-Issue

Signed-off-by: James Tanner <[email protected]>
(cherry picked from commit 0a45a9d)
@patchback patchback bot mentioned this pull request Oct 17, 2024
Merged
jctanner added a commit that referenced this pull request Oct 17, 2024
@patchback @jctanner
[PR #2271/0a45a9de backport][stable-4.10] Merge unique auth classes i…
c667efe 
…n the keycloak dynaconf hook. (#2318)

Merge unique auth classes in the keycloak dynaconf hook. (#2271)

Refactor the auth class injection code to be more aware of dab requirements and AAP upgrades.

No-Issue

Signed-off-by: James Tanner <[email protected]>
(cherry picked from commit 0a45a9d)

Co-authored-by: jctanner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rochacbruno rochacbruno rochacbruno approved these changes

Assignees
No one assigned
Labels
backport-4.10 multi-commit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jctanner @rochacbruno