fix: web-components element rendering exception #1903
+132
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThis pull request addresses a rendering exception in web-components by updating the rendering logic for Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
| }); | ||
| observer.observe(this, { | ||
| characterData: true, | ||
| childList: true, | ||
| characterDataOldValue: true, | ||
| }); | ||
|
|
||
| updateHTML(this); |
There was a problem hiding this comment.
Ensure that updateHTML(this) is called after the observer is set up to guarantee that the initial HTML content is rendered correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
#1882
💡 Background and solution
see #1882 , since the G engine has abandoned support for numerical units in element attribute values, the official documentation examples need to be updated to ensure normal rendering.
On the other hand, the
g-htmlelement cannot be rendered on the first screen because the rendering logic only occurs when the attributes are updated. By default, triggering a rendering once can solve the problem.📝 Changelog
☑️ Self Check before Merge