Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI test that prepares and test python client #44007

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Nov 14, 2024

The test for python client require locally installed airflow with some providers prepared from sources. We have been preparing the selected packages and installing them, but sometimes this required to add new package there.

To make it simpler, we can instead prepare and install all the packages - this will be pretty fast with uv and we will avoid to manually modify the CI tests every time we add some package that requires installation.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

The test for python client require locally installed airflow with
some providers prepared from sources. We have been preparing the
selected packages and installing them, but sometimes this required
to add new package there.

To make it simpler, we can instead prepare and install all the
packages - this will be pretty fast with `uv` and we will avoid
to manually modify the CI tests every time we add some package
that requires installation.
@potiuk potiuk force-pushed the improve-openapi-client-tests branch from fe7f0e0 to 9138f5f Compare November 14, 2024 02:20
@potiuk
Copy link
Member Author

potiuk commented Nov 14, 2024

Actually - I've hit the same problem that made the breeze ci image necessary - hard to install Airflow with all dependencies in consistent way in CI (uv wants to build kerberos :). I think I will actually change it to run the client inside breeze - but I will defer it after coming back from Ireland (I am going to be far less available next week).

@potiuk potiuk marked this pull request as draft November 14, 2024 10:38
@potiuk
Copy link
Member Author

potiuk commented Nov 14, 2024

converted to draft for now

@potiuk
Copy link
Member Author

potiuk commented Nov 14, 2024

I will create an issue for that maybe @gopidesupavan or others would like to take that :)

@potiuk
Copy link
Member Author

potiuk commented Nov 14, 2024

I added #44020 describing what needs to be done

@gopidesupavan
Copy link
Member

I will create an issue for that maybe @gopidesupavan or others would like to take that :)

Cool , Interesting one to solve :)

@potiuk
Copy link
Member Author

potiuk commented Nov 14, 2024

I will create an issue for that maybe @gopidesupavan or others would like to take that :)

Cool , Interesting one to solve :)

Indeed :). It touches a bit of everything :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants