Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: replace Airflow config by conx extras in SMTP provider #46219

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hussein-awala
Copy link
Member

This PR introduces some breaking changes to SMTP provider:

The argument from_email is now an optional kwarg in SmtpNotifier, and the argument to became the first positional argument.

Configuring the SmtpNotifier and SmtpHook default values via Airflow SMTP configurations is not supported anymore. You can instead use the SMTP connection configuration to set the default values, where you can use:

  • the connection extra field ssl_context instead of the configuration smtp_provider.ssl_context or email.ssl_context in the SMTP hook.
  • the connection extra field from_email instead of the configuration smtp.smtp_mail_from in SmtpNotifier.
  • the connection extra field subject_template instead of the configuration smtp.templated_email_subject_path in SmtpNotifier.
  • the connection extra field html_content_template instead of the configuration smtp.templated_html_content_path in SmtpNotifier.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add also 2.0.0 in the version section

"pymongo>=4.0.0"
"pymongo>=4.0.0,!=4.11"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was updated by static checks/pre-commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants