Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle some git exceptions when initializing GitDagBundle #46253

Merged
merged 6 commits into from
Feb 3, 2025

Conversation

ephraimbuddy
Copy link
Contributor

Permission error raises GitCommandError, and if the cloned path is manually removed, it will result in a path not found error when cloning from the bare repo path

airflow/dag_processing/bundles/git.py Outdated Show resolved Hide resolved
airflow/dag_processing/bundles/git.py Outdated Show resolved Hide resolved
airflow/dag_processing/bundles/git.py Outdated Show resolved Hide resolved
@ephraimbuddy ephraimbuddy force-pushed the handle-exceptions branch 2 times, most recently from 9a00716 to 5e083e5 Compare January 31, 2025 09:58
airflow/dag_processing/bundles/git.py Outdated Show resolved Hide resolved
ephraimbuddy and others added 6 commits February 3, 2025 10:14
Permission error raises GitCommandError, and if the cloned path is manually removed,
it will result in a path not found error when cloning from the bare repo path
@ephraimbuddy ephraimbuddy merged commit ef66a9f into apache:main Feb 3, 2025
45 checks passed
@ephraimbuddy ephraimbuddy deleted the handle-exceptions branch February 3, 2025 12:25
dabla pushed a commit to dabla/airflow that referenced this pull request Feb 3, 2025
* Handle some git exceptions when initializing GitDagBundle

Permission error raises GitCommandError, and if the cloned path is manually removed,
it will result in a path not found error when cloning from the bare repo path

* Apply suggestions from code review

Co-authored-by: Jed Cunningham <[email protected]>

* fixup! Apply suggestions from code review

* Fix comment

* Update airflow/dag_processing/bundles/git.py

Co-authored-by: Jed Cunningham <[email protected]>

* fix test

---------

Co-authored-by: Jed Cunningham <[email protected]>
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 4, 2025
* Handle some git exceptions when initializing GitDagBundle

Permission error raises GitCommandError, and if the cloned path is manually removed,
it will result in a path not found error when cloning from the bare repo path

* Apply suggestions from code review

Co-authored-by: Jed Cunningham <[email protected]>

* fixup! Apply suggestions from code review

* Fix comment

* Update airflow/dag_processing/bundles/git.py

Co-authored-by: Jed Cunningham <[email protected]>

* fix test

---------

Co-authored-by: Jed Cunningham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants