-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand KPO template_fields, fix Spark k8s operator tests #46268
Conversation
I was interested in this feature so I've bring back staled PR with some extra tests, maybe we can succeed with it this time |
I think, I've found the bug in spark k8s operator test code. Will check and try to fix for affected test and bring the bug issue to fix any other occurrences |
2aeff58
to
0e5df15
Compare
The mentioned bug in the spark k8s operator test is related to mocking and new changes. Previously, tests were failed because the new KPO This led me to understand that calls to Any method call on instance of I believe that all affected tests are fixed now. So there is no need for a new issue. |
0e5df15
to
4016c3d
Compare
LGTM! |
* Add name and hostname to KPO template_fields * Add fetch container mock to name normalization test * Fix bugged tests * Run execute in test_pod_name to get validation fail * Add long name case to KPO unit tests
* Add name and hostname to KPO template_fields * Add fetch container mock to name normalization test * Fix bugged tests * Run execute in test_pod_name to get validation fail * Add long name case to KPO unit tests
Adding name and hostname to KubernetesPodOperator template_fields
kubernetes_tests/test_kubernetes_pod_operator.py
too long name testing flow and add this case to unit testscloses: #43480
Based on previously staled PR
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.