Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autorefresh to dag page #46296

Merged
merged 5 commits into from
Jan 31, 2025
Merged

Conversation

bbovenzi
Copy link
Contributor

Add autorefresh to Dag page for the header, runs list, and tasks list.

This required rebuilding how we get data for the tasks list cards and how we invalidate queries when triggering a dag run.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Jan 30, 2025
@bbovenzi bbovenzi force-pushed the more-autorefreshing branch from 42df309 to 094ba20 Compare January 31, 2025 14:48
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a few questions for my understanding.

airflow/ui/src/pages/Dag/Dag.tsx Outdated Show resolved Hide resolved
airflow/ui/src/pages/Dag/Dag.tsx Outdated Show resolved Hide resolved
airflow/ui/src/utils/query.ts Outdated Show resolved Hide resolved
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@bbovenzi bbovenzi merged commit 52958cf into apache:main Jan 31, 2025
35 checks passed
@bbovenzi bbovenzi deleted the more-autorefreshing branch January 31, 2025 15:58
utkarsharma2 pushed a commit that referenced this pull request Jan 31, 2025
* Add autorefresh to dag page

* remove areActiveRuns check from task list card

* Fix dag header toggle pause

* Check if dag is paused, move to custom hook

* Address PR feedback
Prab-27 pushed a commit to Prab-27/airflow that referenced this pull request Jan 31, 2025
* Add autorefresh to dag page

* remove areActiveRuns check from task list card

* Fix dag header toggle pause

* Check if dag is paused, move to custom hook

* Address PR feedback
amoghrajesh pushed a commit to astronomer/airflow that referenced this pull request Feb 3, 2025
* Add autorefresh to dag page

* remove areActiveRuns check from task list card

* Fix dag header toggle pause

* Check if dag is paused, move to custom hook

* Address PR feedback
dabla pushed a commit to dabla/airflow that referenced this pull request Feb 3, 2025
* Add autorefresh to dag page

* remove areActiveRuns check from task list card

* Fix dag header toggle pause

* Check if dag is paused, move to custom hook

* Address PR feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants