feat: add catalog/schema subcommands to flight_sql_client. #6332
Conversation
With this change basic commands are added to query the catalogs and schemas of a Flight SQL server.
github-actions
bot
added
arrow
There was a problem hiding this comment.
Thank you @nathanielc 👋
This looks like a great contribution
Could you please also add tests for these new commands? I think you should be able to follow the existing pattern in
https://github.com/apache/arrow-rs/blob/master/arrow-flight/tests/flight_sql_client_cli.rs
cc @crepererum
|
Implementation looks good, but I agree with @alamb that a test is required. Doesn't have to be super sophisticated though, it's mostly a smoke test to check that the wiring is sound. |
|
@crepererum @alamb I have added tests, somehow I missed that they existed when I first looked. To make implementing the service easier, I copied the builder pattern from the CommandGetDbSchemas for the CommandGetTableTypes. While its a trivial implementation it makes implementing the service simple as it follows the same pattern as the other commands. |
nathanielc
force-pushed
the
feat/catalogs-cli
branch
2 times, most recently
from
7ce8b54
to
f8d60ee
Compare
Additionally adds a builder pattern for the CommandGetTableTypes similar to CommandGetDbSchemas, while its implementation is trivial it helps to have a pattern to follow when implementing the command.
nathanielc
force-pushed
the
feat/catalogs-cli
branch
from
f8d60ee
to
9c876b4
Compare
|
I've started the CI checks and clippy complaints about a (minor) issue, the overall approach/code looks good though. |
|
@crepererum Thanks I fixed the clippy issue. |
Which issue does this PR close?
Closes #6331
Rationale for this change
Adds the proposed solution from the issue.
What changes are included in this PR?
Are there any user-facing changes?
Yes, the new subcommands on the CLI are documented, producing good help text within the CLI.