-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CASSGO-35 standardize spelling of datacenter #1843
Conversation
@martin-sucha Would yo be able to kick the CI here? |
I'm not seeing an option to trigger the workflow, can you push another commit or rebase? |
e570216
to
cbfcd16
Compare
@joao-r-reis Think someone else needs to merge it. |
Yes, I'm waiting for a second +1 |
I'm good with these changes |
@bgerrity can you update your commit message according to our guidelines? Then I'll merge this. |
cbfcd16
to
9c62009
Compare
Fixed the commit message |
Oh the |
Ok pushed that. |
We typically ask for commits to be squashed into a single commit unless there's a good reason to have multiple commits, also there's a git conflict (I just merged another PR sorry about that). I can resolve the conflict and do the squashing myself if you don't mind this PR not being considered "merged" by Github (I will still keep you as author of the commit) |
db61a9b
to
f955b6c
Compare
Rebased and squashed. |
f955b6c
to
0d1da20
Compare
@bgerrity sorry there's a conflict with the CHANGELOG.md file. Can you rebase and we can commit? |
I'm going to merge #1823 in a second and then I'll hold off on merging PRs until we can get this in otherwise changelog conflicts will keep preventing us from merging this one |
0d1da20
to
623c219
Compare
Pushed it past the conflicts again. |
@jameshartig just merged something before I got to this 😢 we really need to change how we update the changelog @jameshartig let's hold off on merging stuff until we get this one in. @bgerrity sorry to ask you again, one last time I promise. Also can you take the chance and rewrite the commit message title ? "strike datacentre spelling" to "standardize datacenter spelling" maybe? |
623c219
to
80ac8ce
Compare
This change keeps the repo internally consistent in the spelling of "datacenter". The public interface is kept to prevent breakage. Patch by Brendan Gerrity; reviewed by João Reis, James Hartig for CASSGO-35
80ac8ce
to
a45aeea
Compare
Pushed again with the rebase and the new commit message |
Keeps the repo internally consistent. The public interface is kept to prevent breakage.