feat!: bump electron@^29.0.0 w/ supporting changes #263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
electron
Motivation and Context
update to use latest released electron
Description
electron
dependency to^29.0.0
protocol.registerFileProtocol
withprotocol.handle
protocol.interceptFileProtocol
sandbox
setting. (When sandbox is enabled, appears that preload scripts and other require statements fails).sandbox
as optional, or completely migrate tosandbox
. Needs to support Cordova plugin ecosystem. (third-party npm package support)cordova-plugin-device
bridge
communication still functions and results are fetched by third-party npm package and returned to front with methodwindow.device.getInfo(e => console.log(e));
Testing
npm t
cordova run electron --nobuild
scheme
is set,file
becomes inaccessible. (Should mimic previous behavior ofinterceptFileProtocol
)cordova build electron
on macOSChecklist