-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix](recycler) Further fix for #47475 #47486
Merged
dataroaring
merged 4 commits into
apache:master
from
Yukang-Lian:Fix-Recycler-Tmp-Rowset2
Feb 3, 2025
Merged
[Fix](recycler) Further fix for #47475 #47486
dataroaring
merged 4 commits into
apache:master
from
Yukang-Lian:Fix-Recycler-Tmp-Rowset2
Feb 3, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
gavinchou
reviewed
Jan 30, 2025
gavinchou
reviewed
Jan 30, 2025
gavinchou
reviewed
Jan 30, 2025
gavinchou
reviewed
Jan 30, 2025
gavinchou
reviewed
Jan 30, 2025
gavinchou
reviewed
Jan 30, 2025
gavinchou
reviewed
Jan 30, 2025
run buildall |
run buildall |
run buildall |
gavinchou
approved these changes
Feb 2, 2025
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
bobhan1
approved these changes
Feb 2, 2025
Yukang-Lian
added a commit
to Yukang-Lian/doris
that referenced
this pull request
Feb 5, 2025
Related PR: apache#47475 在pr#47475中,我们修复了潜在的少删数据的问题,是通过在delete rowset data函数中添加删除逻辑,删除recycle tablet中漏删的文件,但是那个pr忽略了其中存在的一个判断条件,导致在recycle tablet中漏删的文件被跳过了,没有实际删除。 在此pr中,tmp rowset不再依赖于上述判断条件,尽可能删除每一个rowset数据,包括倒排索引v2的数据,但是普通的rowset不会跳过这个判断条件,因为普通rowset数量过大,如果不跳过,可能会影响删除效率。
gavinchou
pushed a commit
that referenced
this pull request
Feb 5, 2025
16 tasks
gavinchou
pushed a commit
that referenced
this pull request
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #47475
Problem Summary:
在pr#47475中,我们修复了潜在的少删数据的问题,是通过在delete rowset data函数中添加删除逻辑,删除recycle tablet中漏删的文件,但是那个pr忽略了其中存在的一个判断条件,导致在recycle tablet中漏删的文件被跳过了,没有实际删除。
在此pr中,tmp rowset不再依赖于上述判断条件,尽可能删除每一个rowset数据,包括倒排索引v2的数据,但是普通的rowset不会跳过这个判断条件,因为普通rowset数量过大,如果不跳过,可能会影响删除效率。
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)