[ISSUE-883] Transitively export the dependencies of [eventmesh-sdk-java] to other module

[HoffmanZheng]

Fixes ISSUE #883 .

Motivation

eventmesh-sdj-java is a library module, should transitively export the dependencies, which are necessary for development of eventmesh-application.

Modifications

Add gradle plugin java-library in eventmesh-sdk-java

Change the configuration of following dependencies from implementation to api:

• project(":eventmesh-common")
• io.cloudevents:cloudevents-core
• io.cloudevents:cloudevents-json-jackson
• io.openmessaging:openmessaging-api
• org.projectlombok:lombok:1.18.22

Documentation

Not a new feature, thus no doc needed.

[codecov]

Codecov Report

Merging #884 (1cb673d) into master (c055e83) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 1cb673d differs from pull request most recent head 95e0fc4. Consider uploading reports for the commit 95e0fc4 to get more accurate results

@@             Coverage Diff             @@
##             master    #884      +/-   ##
===========================================
- Coverage      7.09%   7.06%   -0.03%     
  Complexity      442     442              
===========================================
  Files           346     346              
  Lines         21695   21691       -4     
  Branches       2415    2411       -4     
===========================================
- Hits           1539    1533       -6     
- Misses        20039   20041       +2     
  Partials        117     117              

Impacted Files	Coverage Δ
...ava/org/apache/eventmesh/common/utils/IPUtils.java	34.25% <0.00%> (-5.56%)	⬇️
...rg/apache/eventmesh/runtime/trace/LogExporter.java	0.00% <0.00%> (ø)
...l/tcp/client/recommend/EventMeshRecommendImpl.java	0.00% <0.00%> (ø)
.../tcp/client/session/push/DownStreamMsgContext.java	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c055e83...95e0fc4. Read the comment docs.

[HoffmanZheng]

deleted, see below.

[HoffmanZheng]

Though maven-publish is included in the project, there should be a committor to do the related test.

[HoffmanZheng]

After I use the java-library and change the dependency configuration to api, the built jar file still does not contain the dependencies.
Thus the shadow plugin used here to generate a fat jar. (for your reference)

[ruanwenjun]

Good catch. Right now, the scope of eventmesh-common in eventmesh-sdk-java is implementation, so if we want to use eventmesh-sdk-java in our app, we need to add the eventmesh-common to our dependency. We need to change the scope from implementation to api to solve this.

And I think we don't need to make a shawdow jar. cc @xwm1992

[HoffmanZheng]

Good catch. Right now, the scope of eventmesh-common in eventmesh-sdk-java is implementation, so if we want to use eventmesh-sdk-java in our app, we need to add the eventmesh-common to our dependency. We need to change the scope from implementation to api to solve this.

And I think we don't need to make a shawdow jar. cc @xwm1992

Currently I'm trying to use the following script to generate a fat jar of [eventmesh-sdk-java] (without the usage of shadow plugin), sometimes it works. Mark the PR work in progress.

jar {
    from {
        configurations. runtimeClasspath.filter{ it.exists() }.collect { it.isDirectory() ? it : zipTree(it) }
    }
}

[ruanwenjun]

Good catch. Right now, the scope of eventmesh-common in eventmesh-sdk-java is implementation, so if we want to use eventmesh-sdk-java in our app, we need to add the eventmesh-common to our dependency. We need to change the scope from implementation to api to solve this.
And I think we don't need to make a shawdow jar. cc @xwm1992

Currently I'm trying to use the following script to generate a fat jar of [eventmesh-sdk-java] (without the usage of shadow plugin), sometimes it works. Mark the PR work in progress.

jar {
    from {
        configurations. runtimeClasspath.filter{ it.exists() }.collect { it.isDirectory() ? it : zipTree(it) }
    }
}

I suggest we just change the scope of eventmesh-commom to spi is enough.

[HoffmanZheng]

I used to use the gradle jar and mvn install:install-file to do dependencies resolving test, and it does not work.
Rather using gradle publishToMavenLocal, the dependencies could be transitively exported to other module!

[qqeasonchen]

@HoffmanZheng any update？

[HoffmanZheng]

@HoffmanZheng any update？

updated

[ruanwenjun]

LGTM