feat(java): Implement classId related logic #1661
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: LiangliangSui <[email protected]>
|
Hi @chaokunyang , could you help me check if there is any problem with the implementation logic? If there is no problem, I will handle CI related errors. |
chaokunyang
reviewed
May 30, 2024
| @@ -160,45 +160,45 @@ public class ClassResolver { | |||
| // bit 0 unset indicates class is written as an id. | |||
| public static final byte USE_CLASS_VALUE_FLAG = 0b1; | |||
| // preserve 0 as flag for class id not set in ClassInfo` | |||
| public static final short NO_CLASS_ID = (short) 0; | |||
| public static final short LAMBDA_STUB_ID = 1; | |||
There was a problem hiding this comment.
Different languages have different type systems. The type id for java native serialization and xlang serialization may be different.
There was a problem hiding this comment.
Ok, I see, so we need to define a new set of TypeId in java for xlang spec?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implementing xlang_spec typeId.
Related issues
#1413
Does this PR introduce any user-facing change?
Benchmark