Forchapeatl type meta #1825
Forchapeatl type meta #1825
Conversation
javascript/packages/fury/lib/fury.ts
Outdated
| @@ -44,6 +48,8 @@ export default class { | |||
| this.referenceResolver = new ReferenceResolver(this.binaryReader); | |||
| this.classResolver.init(this); | |||
| this.anySerializer = new AnySerializer(this); | |||
| this.typeMeta = new TypeMeta(BigInt(0),[]); | |||
There was a problem hiding this comment.
from_bytes in TypeMeta is a static method, if you want to call it, you should replace by this.typeMeta = TypeMeta
| return ` | ||
| ${this.builder.writer.int32(expectHash)}; | ||
| ${this.builder.writer.buffer(`Buffer.from("${metaInformation.toString("base64")}", "base64")`)}; | ||
| ${this.builder.writer.buffer(binaryBase64)}; |
There was a problem hiding this comment.
if the base64 string is "AQAAAAAAAAACgATsEgsABQg="
the code you generated will be bw.buffer(AQAAAAAAAAACgATsEgsABQg=); it includes syntax error
|
Hi @theweipeng on line 147 , when I do this - ${this.builder.typeMeta.from_bytes(this.builder.reader.ownName())}
+ ${this.builder.reader.buffer(buffer.byteLength)}I pass 3 test Please for a hint on what I am missing. |
Why did you remove reading the typeMeta? I am confused |
@theweipeng I was just experimenting . After solving the syntax error, I was trying to figure out a way to pass the tests. |
Ensure that the byte length consumed from the reader matches the length written to the buffer in the writeStmt. In the context of your code, it should be expressed as |
What does this PR do?
Related issues
Does this PR introduce any user-facing change?
Benchmark