Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize : Skip sending some request if client-version is v0 #6998

Open
wants to merge 8 commits into
base: 2.x
Choose a base branch
from

Conversation

Bughue
Copy link
Contributor

@Bughue Bughue commented Nov 14, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

  1. 新增了客户端版本+msgType来判断是否跳过的逻辑
  2. 这个功能在sendAsyncsendSync都加上了,保证代码逻辑的一致性,但sendSync的“if”是不会进的。
  3. sendSync的时候会返回一个VersionNotSupportMessage。目前来说TC使用sendSync的逻辑不会做这种判断,后续如果有skip的情况就需要在接收的时候先判断类型,而不是直接强转。

  1. Added client version + msgType to determine whether to skip the logic.
  2. this feature is added to both sendAsync and sendSync to ensure the consistency of code logic, but the “if” of sendSync will not be entered.
  3. sendSync will return a VersionNotSupportMessage. at present, TC use sendSync logic will not do this kind of judgment, and then if there is a skip case you need to judge the type of the first time you receive, rather than directly force the transfer.

Translated with DeepL.com (free version)

Ⅱ. Does this pull request fix one issue?

fixes #6999

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@xingfudeshi xingfudeshi changed the title Optimize : Skip sending some request if client-version is v0 optimize : Skip sending some request if client-version is v0 Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0-client(<0.7.1) can not decode UndoLogDeleteRequest
1 participant