MINOR: Add javadocs to AbstractMergedSortedCacheStoreIterator #18772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fonsdant
force-pushed
the
minor/improve-javadoc-abstract-merged-sorted-cache-store-iterator
branch
from
882d124 to
df4fa92
Compare
ableegoldman
approved these changes
Feb 1, 2025
...in/java/org/apache/kafka/streams/state/internals/AbstractMergedSortedCacheStoreIterator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Joao Pedro Fonseca Dantas <[email protected]>
|
@ableegoldman, thanks for reviewing! Updated with your suggestion. |
|
Merged to trunk. Thanks for the javadocs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing PR #18287, I wrote some javadocs to help me understand the
AbstractMergedSortedCacheStoreIterator. Maybe we could add them to help the next developers getting into it. How about it?@mjsax, @agavra, @ableegoldman