Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Fix wrong config property in KafkaConfigTest #18815

Conversation

mingyen066
Copy link
Contributor

@mingyen066 mingyen066 commented Feb 6, 2025

Based on the discussion: https://github.com/apache/kafka/pull/18547/files#r1944140562

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added triage PRs from the community core Kafka Broker tests Test fixes (including flaky tests) small Small PRs labels Feb 6, 2025
Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Fix, LGTM

@chia7712 chia7712 merged commit 34e7136 into apache:trunk Feb 6, 2025
10 checks passed
chia7712 pushed a commit that referenced this pull request Feb 6, 2025
@chia7712
Copy link
Member

chia7712 commented Feb 6, 2025

cherry-pick to 4.0

@github-actions github-actions bot removed the triage PRs from the community label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-approved core Kafka Broker small Small PRs tests Test fixes (including flaky tests)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants