-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add STM32H5 architecture documentation. #15771
Conversation
aaf1d9f
to
efb9ec4
Compare
[Experimental Bot, please feedback here] Yes, this PR appears to meet the basic NuttX requirements, although it could be more thorough. While it addresses the key areas, it lacks specific details in a few sections, which could hinder review and acceptance. Here's a breakdown:
Recommendation: Strengthen the Testing section with concrete examples. Be specific about the documentation files changed in the Impact section. Consider creating a related issue if one doesn't exist and link it in the Summary. These small additions will significantly improve the PR's clarity and chances of acceptance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kywwilson11 you missed to include a picture of the board.
All the boards Documentation/ needs to include a picture of the board. Some are missing because they are old contribution or someone failed to ask it during the review!
Add documentation for nucleo-h563zi development board. Removed whitespace at the end of lines. Fixed column formatting. Fixed Title overline too short error. Added image to nucleo-h563zi documentation.
14ddf73
to
a9aae40
Compare
I added an image of the Nucleo-H563ZI, and included it in the board documentation. Thank you for the feedback. |
Summary
Added documentation for STM32H5 Architecture and Nucleo-H563ZI board.
There is support for a handful of peripherals right now. Adding documentation will hopefully encourage others to contribute to the STM32H5 port.
Impact
No impact to code. Only documentation will be updated for STM32H5.
Testing
Used online rst previewer to check formatting in index.rst files.