Fix macOS build error. #15774
Fix macOS build error. #15774
Conversation
github-actions
bot
added
Area: OS Components
1. fix apache#14774. Change the defconfig of libcxxtest and select libcxxabi by default to fix sim:libcxxtest build in macOS CI can't find cxxabi.h. 2. fix apache#15491. libcxxabi cannot be used with uclibc, so when compiling macos sim, libcxxabi cannot be selected by default in Kconfig. Signed-off-by: cuiziwei <[email protected]>
cuiziweizw
force-pushed
the
macOS_libcxxabi
branch
from
43ac2bf to
20a9a81
Compare
ok |
| @@ -71,7 +71,6 @@ if !LIBCXXMINI | |||
|
|
|||
| choice | |||
| prompt "C++ low level library select" | |||
| default LIBCXXABI if ARCH_SIM && HOST_MACOS | |||
There was a problem hiding this comment.
why not enable LIBCXXABI by default if ARCH_SIM ?
There was a problem hiding this comment.
cause select LIBCXXMINI by default. if select LIBCXXABI, we need to select LIBCXX by default if ARCH_SIM
There was a problem hiding this comment.
see line 70, this choice snippet is no LIBCXXMINI case
There was a problem hiding this comment.
I mean why not just remove HOST_MACOS:
default LIBCXXABI if ARCH_SIM && HOST_MACOS
->
default LIBCXXABI if ARCH_SIM
There was a problem hiding this comment.
Some sim defconfig(like https://github.com/apache/nuttx/blob/master/boards/sim/sim/sim/configs/cxxtest/defconfig) enable uclibcxx by default. If libcxxabi is selected by default, there may also be compilation problems.
Summary
fix [BUG] macOS CI:
sim:libcxxtestcan't find cxxabi.h #14774.Change the defconfig of libcxxtest and select libcxxabi by default.
fix [BUG] Mirror of NuttX: All macOS Jobs are broken #15491.
libcxxabi cannot be used with uclibc, so when compiling macos sim, libcxxabi cannot be selected by default in Kconfig.
Impact
macos sim
Testing
ci test