-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards/stm32l4: Fix all boards to support proper stm32_bringup.c #15817
base: master
Are you sure you want to change the base?
Conversation
Many STM32L4 boards are missing stm32_bringup.c. That confusion was created when stm32_appinit.c was created. It introduced a new way to do the board initialization without depending on NSH arch specific initialization. Signed-off-by: Alan C. Assis <[email protected]>
Many STM32L4 boards are missing stm32_bringup.c. That confusion was created when stm32_appinit.c was created. It introduced a new way to do the board initialization without depending on NSH arch specific initialization. Signed-off-by: Alan C. Assis <[email protected]>
Many STM32L4 boards are missing stm32_bringup.c. That confusion was created when stm32_appinit.c was created. It introduced a new way to do the board initialization without depending on NSH arch specific initialization. Signed-off-by: Alan C. Assis <[email protected]>
[Experimental Bot, please feedback here] No, this PR does not fully meet the NuttX requirements. While it provides a summary of the what and why, it lacks crucial details. Here's a breakdown of what's missing:
In short, the PR needs to be significantly more detailed to meet the requirements. It needs to clearly explain the technical implementation of the change, thoroughly address all aspects of its impact, and provide concrete evidence of testing on specific platforms. |
Many STM32L4 boards are missing stm32_bringup.c. That confusion was created when stm32_appinit.c was created. It introduced a new way to do the board initialization without depending on NSH arch specific initialization. Signed-off-by: Alan C. Assis <[email protected]>
Many STM32L4 boards are missing stm32_bringup.c. That confusion was created when stm32_appinit.c was created. It introduced a new way to do the board initialization without depending on NSH arch specific initialization. Signed-off-by: Alan C. Assis <[email protected]>
3568d44
to
86980a4
Compare
Thank you @acassis !! I played a bit some time ago with STM32 boards and noticed the inconsistencies, thank you for the cleanup!! I have some of these boards, will test on hardware and report back :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update the title to include the modified area
ex:
boards/stm32l4r9ai-disco: Add support to bringup
thanks
Done! Since it update many boards I used boards/stm32l4 |
in the future please specify boards also on the commit title |
Summary
Many STM32L4 boards are missing stm32_bringup.c. That confusion
was created when stm32_appinit.c was created. It introduced a new
way to do the board initialization without depending on NSH arch
specific initialization.
Impact
Fix boards bringup process.
Testing
Building