qemu-armv7a Ivshmem config and document update #15818

CV-Bowen · 2025-02-12T07:57:58Z

Summary

commit bfd8f01
Author: Bowen Wang [email protected]
Date: Wed Feb 12 15:46:59 2025 +0800

arm/qemu-armv7a: optimize the rpproxy and rpserver configs and doc

add discard-data=on in proxy launch command, so the proxy side
will clean the share memory to make sure that the shared memory is clean
every time server and proxy are started.

Signed-off-by: Bowen Wang <[email protected]>

commit 7cd275b
Author: Bowen Wang [email protected]
Date: Wed Feb 12 15:46:15 2025 +0800

rpmsgblk_server: fix the syslog format warning

misc/rpmsgblk_server.c:135:16: warning: format '%d' expects argument of type 'int', but argument 3 has type 'int32_t' {aka 'long int'} [-Wformat=]
  135 |           ferr("block device open failed, ret=%d\n", msg->header.result);
      |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~~~~~~~~~~~~~
      |                                                                 |
      |                                                                 int32_t {aka long int}
misc/rpmsgblk_server.c:135:48: note: format string is defined here
  135 |           ferr("block device open failed, ret=%d\n", msg->header.result);
      |                                               ~^
      |                                                |
      |                                                int
      |                                               %ld
misc/rpmsgblk_server.c: In function 'rpmsgblk_close_handler':
misc/rpmsgblk_server.c:170:16: warning: format '%d' expects argument of type 'int', but argument 3 has type 'int32_t' {aka 'long int'} [-Wformat=]
  170 |           ferr("block device close failed, ret=%d\n", msg->header.result);
      |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~~~~~~~~~~~~~
      |                                                                  |
      |                                                                  int32_t {aka long int}
misc/rpmsgblk_server.c:170:49: note: format string is defined here
  170 |           ferr("block device close failed, ret=%d\n", msg->header.result);
      |                                                ~^
      |                                                 |
      |                                                 int
      |                                                %ld

Signed-off-by: Bowen Wang <[email protected]>

Impact

ivshmem configs

Testing

testing with qemu-armv7a:rpserver_ivshmem qemu-armv7a:rpproxy_ivshmem with rpmsg ping

qemu-armv7a test result

server> rptun ping all 1 1 1 1
[   17.809022] [ 5] [ EMERG] [server] ping times: 1
[   17.809780] [ 5] [ EMERG] [server] buffer_len: 2032, send_len: 17
[   17.811340] [ 5] [ EMERG] [server] avg: 0 s, 54224016 ns
[   17.812204] [ 5] [ EMERG] [server] min: 0 s, 54224016 ns
[   17.813158] [ 5] [ EMERG] [server] max: 0 s, 54224016 ns
[   17.814339] [ 5] [ EMERG] [server] rate: 0.002508 Mbits/sec
server> [   68.740115] [ 5] [ EMERG] [proxy] ping times: 1
[   68.741721] [ 5] [ EMERG] [proxy] buffer_len: 2032, send_len: 17
[   68.743624] [ 5] [ EMERG] [proxy] avg: 0 s, 46184560 ns
[   68.744854] [ 5] [ EMERG] [proxy] min: 0 s, 46184560 ns
[   68.746030] [ 5] [ EMERG] [proxy] max: 0 s, 46184560 ns
[   68.747437] [ 5] [ EMERG] [proxy] rate: 0.002944 Mbits/sec

server> 
server> uname -a
NuttX server 12.7.0 381d3fe64f4-dirty Feb 12 2025 15:44:48 arm qemu-armv7a
server>

CV-Bowen · 2025-02-12T07:58:57Z

@anchao @acassis @xiaoxiang781216 @GUIDINGLI Could you help review this PR?

anchao · 2025-02-12T08:27:21Z

please discard roles changes:
#15810

CV-Bowen · 2025-02-12T09:21:26Z

@anchao OK, I missed #15810, let's merge #15810 first and I will rebase this PR.

jerpelea

please move the driver chanegs to a separate PR

please rename commit
rpmsgblk_server: fix the syslog format warning title to

drivers/rpmsgblk_server: fix the syslog format warning

acassis

@CV-Bowen please include a Documentation/ to rpproxy_ivshmem and rpserver_ivshmem board profiles explaining what it does and how to test/validate it.

misc/rpmsgblk_server.c:135:16: warning: format '%d' expects argument of type 'int', but argument 3 has type 'int32_t' {aka 'long int'} [-Wformat=] 135 | ferr("block device open failed, ret=%d\n", msg->header.result); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~ | | | int32_t {aka long int} misc/rpmsgblk_server.c:135:48: note: format string is defined here 135 | ferr("block device open failed, ret=%d\n", msg->header.result); | ~^ | | | int | %ld misc/rpmsgblk_server.c: In function 'rpmsgblk_close_handler': misc/rpmsgblk_server.c:170:16: warning: format '%d' expects argument of type 'int', but argument 3 has type 'int32_t' {aka 'long int'} [-Wformat=] 170 | ferr("block device close failed, ret=%d\n", msg->header.result); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~ | | | int32_t {aka long int} misc/rpmsgblk_server.c:170:49: note: format string is defined here 170 | ferr("block device close failed, ret=%d\n", msg->header.result); | ~^ | | | int | %ld Signed-off-by: Bowen Wang <[email protected]>

add discard-data=on in proxy launch command, so the proxy side will clean the share memory to make sure that the shared memory is clean every time server and proxy are started. Signed-off-by: Bowen Wang <[email protected]>

CV-Bowen · 2025-02-12T15:08:17Z

@anchao Done
@jerpelea Update commit messages done, and I found this warning when I enable RPMSGBLK_SERVER, so I think place this patch in this PR is reasonable.
@acassis There is alreay a document about the rpserver_ivshmem and rpproxy_ivshmem

acassis · 2025-02-12T15:17:52Z

@CV-Bowen I cannot find it:

https://nuttx.apache.org/docs/latest/search.html?q=rpserver_ivshmem&check_keywords=yes&area=default

https://nuttx.apache.org/docs/latest/search.html?q=rpproxy_ivshmem&check_keywords=yes&area=default#

All new board profiles need to be documented to let users know what they are suppose to do

anchao · 2025-02-13T01:52:55Z

@CV-Bowen I cannot find it:

https://nuttx.apache.org/docs/latest/search.html?q=rpserver_ivshmem&check_keywords=yes&area=default

https://nuttx.apache.org/docs/latest/search.html?q=rpproxy_ivshmem&check_keywords=yes&area=default#

All new board profiles need to be documented to let users know what they are suppose to do

@acassis @CV-Bowen @yf13

I added the missing qemu-armv8a/ivshmem chapter

#15827

CV-Bowen · 2025-02-13T02:36:52Z

Documentation/platforms/arm/qemu/boards/qemu-armv7a/index.rst
@acassis This has documented the qemu armv7a rpproxy_ivshmem and rpserver_ivshmem configs usages.

jerpelea · 2025-02-13T09:11:48Z

@anchao Done @jerpelea Update commit messages done, and I found this warning when I enable RPMSGBLK_SERVER, so I think place this patch in this PR is reasonable. @acassis There is alreay a document about the rpserver_ivshmem and rpproxy_ivshmem

I think that the driver commit should be in a separate PR since the fix is independent from the other commit

CV-Bowen · 2025-02-13T15:13:01Z

@jerpelea I enable the CONFIG_BLK_RPMSG_SERVER in rpproxy_server and found this compile warning, so I think this fix is related with other commit in this PR?

anchao · 2025-02-14T06:45:15Z

These two commits are actually interdependent

Solving the compiler warning alone will not be reflected in CI, it depends on the corresponding kconfig being enabled
After enabling config, there will be compilation warnings and CI will not pass normally
I think we cannot split PRs completely according to the directory structure, the granularity of the feature set may be better

github-actions bot added Area: Documentation Improvements or additions to documentation Area: Drivers Drivers issues Board: arm Board: arm64 Size: S The size of the change in this PR is small labels Feb 12, 2025

jerpelea reviewed Feb 12, 2025

View reviewed changes

acassis reviewed Feb 12, 2025

View reviewed changes

CV-Bowen added 2 commits February 12, 2025 22:43

CV-Bowen force-pushed the ivshmem-configs branch from eef3f56 to cb0efe6 Compare February 12, 2025 14:44

github-actions bot removed the Board: arm64 label Feb 12, 2025

anchao approved these changes Feb 13, 2025

View reviewed changes

CV-Bowen changed the title ~~qemu-armv7a and armv8a Ivshmem configs update~~ qemu-armv7a Ivshmem configs update Feb 13, 2025

CV-Bowen changed the title ~~qemu-armv7a Ivshmem configs update~~ qemu-armv7a Ivshmem config and document update Feb 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

qemu-armv7a Ivshmem config and document update #15818

qemu-armv7a Ivshmem config and document update #15818

CV-Bowen commented Feb 12, 2025 •

edited

Loading

CV-Bowen commented Feb 12, 2025

anchao commented Feb 12, 2025

CV-Bowen commented Feb 12, 2025 •

edited

Loading

jerpelea left a comment

acassis left a comment

CV-Bowen commented Feb 12, 2025 •

edited

Loading

acassis commented Feb 12, 2025

anchao commented Feb 13, 2025

CV-Bowen commented Feb 13, 2025

jerpelea commented Feb 13, 2025

CV-Bowen commented Feb 13, 2025 •

edited

Loading

anchao commented Feb 14, 2025

qemu-armv7a Ivshmem config and document update #15818

Are you sure you want to change the base?

qemu-armv7a Ivshmem config and document update #15818

Conversation

CV-Bowen commented Feb 12, 2025 • edited Loading

Summary

Impact

Testing

CV-Bowen commented Feb 12, 2025

anchao commented Feb 12, 2025

CV-Bowen commented Feb 12, 2025 • edited Loading

jerpelea left a comment

Choose a reason for hiding this comment

acassis left a comment

Choose a reason for hiding this comment

CV-Bowen commented Feb 12, 2025 • edited Loading

acassis commented Feb 12, 2025

anchao commented Feb 13, 2025

CV-Bowen commented Feb 13, 2025

jerpelea commented Feb 13, 2025

CV-Bowen commented Feb 13, 2025 • edited Loading

anchao commented Feb 14, 2025

CV-Bowen commented Feb 12, 2025 •

edited

Loading

CV-Bowen commented Feb 12, 2025 •

edited

Loading

CV-Bowen commented Feb 12, 2025 •

edited

Loading

CV-Bowen commented Feb 13, 2025 •

edited

Loading