libs/libc/modlib/modlib_bind.c: Fix system crash if modlib_bind fails

[jlaitine]

Summary

Addrenv is changed to the newly created process' one in the beginning of modlib_bind, and needs to be changed back always when returning from the function; also in error cases.

This fixes a system crash in case where linking of a new process fails in modlib_bind. In the error case the modlib_bind returned with error code, but with wrong address environment.

Impact

Fixes a crashing bug in platforms using CONFIG_ARCH_ADDRENV.

Testing

Tested on imx93 and mpfs platforms.

[xiaoxiang781216]

remove indent

[lupyuen]

@nuttxpr test milkv_duos:nsh

[nuttxpr]

[Experimental Bot, please feedback here]

Build and Test Successful (milkv_duos:nsh)
https://gitlab.com/lupyuen/nuttx-build-log/-/snippets/4806168

$ git clone https://github.com/tiiuae/nuttx nuttx --branch fix_system_crash_in_modlib_bind
$ git clone https://github.com/apache/nuttx-apps apps --branch master
$ pushd nuttx
$ git reset --hard HEAD
HEAD is now at feb82cc1bd libs/libc/modlib/modlib_bind.c: Fix system crash if modlib_bind fails
$ popd
$ pushd apps
$ git reset --hard HEAD
HEAD is now at 7f424c3e8 nshlib/builtin: check background task before restore the signal
$ popd
NuttX Source: https://github.com/apache/nuttx/tree/feb82cc1bd7ac2feab4ea0389a823f30673845c7
NuttX Apps: https://github.com/apache/nuttx-apps/tree/7f424c3e8ddaa0a6a828175b8e4205c1cc0a2a8a
$ cd nuttx
$ tools/configure.sh milkv_duos:nsh
$ make -j
$ make -j export
$ pushd ../apps
$ ./tools/mkimport.sh -z -x ../nuttx/nuttx-export-10.4.0.tar.gz
$ make -j import
$ popd
$ genromfs -f initrd -d ../apps/bin -V NuttXBootVol
$ head -c 65536 /dev/zero
$ cat nuttx.bin /tmp/nuttx.pad initrd
$ scp Image tftpserver:/tftpboot/Image-sg2000
$ ssh tftpserver ls -l /tftpboot/Image-sg2000
$ cd /home/luppy/nuttx-build-farm
$ ssh tftpserver
OpenSBI v0.9
nsh> uname -a
NuttX 10.4.0 feb82cc1bd Feb 13 2025 17:24:22 risc-v milkv_duos
nsh> ostest
arena       81000    81000
ordblks         2        3
mxordblk    7cff8    78ff8
uordblks     2660     4570
fordblks    7e9a0    7ca90
user_main: Exiting
ostest_main: Exiting with status 0
nsh> Now running https://github.com/lupyuen/nuttx-build-farm/blob/main/oz64-power.sh off
----- Power off Oz64
[]

[lupyuen]

Tested OK on Real Hardware: Oz64 SG2000 RISC-V SBC. Thanks :-)

• libs/libc/modlib/modlib_bind.c: Fix system crash if modlib_bind fails #15830 (comment)