[API-DRAFT]Add spark-core-starter module Code splitting for old and new engines #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code splitting for old and new engines
ruanwenjun
requested changes
May 25, 2022
seatunnel-core/seatunnel-spark-starter/src/main/bin/start-seatunnel-spark.sh
Outdated
Show resolved
Hide resolved
seatunnel-core/seatunnel-spark-starter/src/test/resources/spark_application.conf
Show resolved
Hide resolved
| } | ||
|
|
||
| @Override | ||
| public List<BaseSource<SparkEnvironment>> getSources() { |
There was a problem hiding this comment.
In our new spark starter module we will not use this class, BaseSource is used for old API.
…unnel-spark.sh Co-authored-by: Wenjun Ruan <[email protected]>
ruanwenjun
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
spark-core-startermodule Code splitting for old and new engines