Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(be/deps): add comments for un-greppable Python dependencies #32259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hainenber
Copy link
Contributor

@hainenber hainenber commented Feb 14, 2025

build(be/deps): remove unused bottleneck library

SUMMARY

We don't use the bottleneck library anywhere in the codebase so it's best be removed to reduce attack surface and download rate

image

Edit: change the PR's content to add comments about purpose of un-greppable Python deps

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

All CI checks should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

  • You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
  • You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
  • Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
  • Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
  • Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

  • Check out our docs on how you can make Korbit work best for you and your team.
  • Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings
Setting Value
Review Schedule Automatic excluding drafts
Max Issue Count 10
Automatic PR Descriptions
Issue Categories
Category Enabled
Documentation
Logging
Error Handling
Readability
Design
Performance
Security
Functionality

Feedback and Support

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.45%. Comparing base (76d897e) to head (65c6d7b).
Report is 1446 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #32259       +/-   ##
===========================================
+ Coverage   60.48%   83.45%   +22.96%     
===========================================
  Files        1931      546     -1385     
  Lines       76236    39097    -37139     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32629    -13485     
+ Misses      28017     6468    -21549     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.49% <ø> (-0.67%) ⬇️
javascript ?
mysql 75.85% <ø> (?)
postgres 75.92% <ø> (?)
presto 53.02% <ø> (-0.78%) ⬇️
python 83.45% <ø> (+19.96%) ⬆️
sqlite 75.43% <ø> (?)
unit 61.06% <ø> (+3.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hainenber We use this library to boost Pandas.

@hainenber
Copy link
Contributor Author

Thanks Michael, TIL about pandas's perf deps 🫨

I'll add comments so other folks wont raise similar PRs in the future.

@hainenber hainenber changed the title build(be/deps): remove unused bottleneck library chore(be/deps): add comments for un-greppable Python dependencies Feb 15, 2025
@hainenber hainenber force-pushed the chores/remove-unused-bottleneck-pypi-dep branch from 65c6d7b to b082b27 Compare February 15, 2025 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants